Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "locking" dependencies when building / testing current project #1058

Merged
merged 1 commit into from
Feb 14, 2019
Merged

fix "locking" dependencies when building / testing current project #1058

merged 1 commit into from
Feb 14, 2019
+123 −2

Conversation

KristofferC
Copy link
Member

No description provided.

KristofferC
KristofferC commented Feb 13, 2019
View reviewed changes
test/test_packages/BuildProjectFixedDeps/Manifest.toml
deps = ["Dates", "Distributed", "Mmap", "Sockets", "Test", "Unicode"]
git-tree-sha1 = "fec8e4d433072731466d37ed0061b3ba7f70eeb9"
uuid = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
version = "0.19.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We make sure that this version is used when building, previously it would update to latest JSON 0.20+.

bors bot added a commit that referenced this pull request Feb 13, 2019
@bors
Try #1058:
5aea71c
fredrikekre
fredrikekre reviewed Feb 13, 2019
View reviewed changes
test/pkg.jl Outdated Show resolved Hide resolved
@JuliaLang JuliaLang deleted a comment from bors bot Feb 13, 2019
@KristofferC
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Feb 13, 2019
@bors
Try #1058:
884fb56
@bors
Copy link
Contributor

bors bot commented Feb 13, 2019

try

Build failed

@KristofferC
Copy link
Member Author

Build suceeded after restarting the mac worker (was a network error).

@fredrikekre
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Feb 14, 2019
@bors @KristofferC
Merge #1058
5fb3c4c 
1058: fix "locking" dependencies when building / testing current project r=fredrikekre a=KristofferC



Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
@fredrikekre
Copy link
Member

bors r-

@bors
Copy link
Contributor

bors bot commented Feb 14, 2019

Canceled

@fredrikekre
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Feb 14, 2019
@bors @KristofferC
Merge #1058
9235922 
1058: fix "locking" dependencies when building / testing current project r=fredrikekre a=KristofferC



Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 14, 2019

Build succeeded

@bors bors bot merged commit b48c53f into master Feb 14, 2019
@bors bors bot deleted the kc/fix_lock branch February 14, 2019 16:12
fredrikekre pushed a commit that referenced this pull request Feb 26, 2019
@KristofferC @fredrikekre
fix "locking" dependencies when building / testing current project
9f7aa2a 
(cherry picked from commit b48c53f, PR #1058)
fredrikekre pushed a commit that referenced this pull request Feb 26, 2019
@KristofferC @fredrikekre
fix "locking" dependencies when building / testing current project
6134e57 
(cherry picked from commit b48c53f, PR #1058)
fredrikekre pushed a commit that referenced this pull request Apr 15, 2019
@KristofferC @fredrikekre
fix "locking" dependencies when building / testing current project
8416d3c 
(cherry picked from commit b48c53f, PR #1058)
@fredrikekre fredrikekre mentioned this pull request May 17, 2019
Closed
@fredrikekre fredrikekre mentioned this pull request Jun 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KristofferC @fredrikekre